<html>
<head><meta charset="utf-8"><title>git dep getting updated in crater on 1.53 beta · t-cargo · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/index.html">t-cargo</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html">git dep getting updated in crater on 1.53 beta</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="239601966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239601966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239601966">(May 20 2021 at 14:34)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="116015">@Alex Crichton</span> -- wondering if you have any insight here. In the 1.53 beta crater run, we're seeing a lot of failures due to regenerating the lockfile, I think as a result of <a href="https://github.com/rust-lang/cargo/pull/9392">https://github.com/rust-lang/cargo/pull/9392</a> . My guess is this is sort of similar to <a href="https://github.com/rust-lang/cargo/pull/9392">https://github.com/rust-lang/cargo/pull/9392</a>, where we weren't able to use patch entries. The logs show that "error: the lock file /workspace/builds/worker-7/source/Cargo.lock needs to be updated but --locked was passed to prevent this" -- but my guess is that in practice, this is not the case; we should not need to update the lock file on the new Cargo version.</p>
<p>Maybe the problem is that generate-lockfile for git deps is not respecting the previous lockfile's pinned version, I'm not sure... </p>
<p>Sample logs;</p>
<ul>
<li>1.52 - <a href="https://crater-reports.s3.amazonaws.com/beta-1.53-1/1.52.1/gh/jonlamb-gh.pinephone-rs-display-prototype/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.53-1/1.52.1/gh/jonlamb-gh.pinephone-rs-display-prototype/log.txt</a></li>
<li>1.53 - <a href="https://crater-reports.s3.amazonaws.com/beta-1.53-1/beta-2021-05-08/gh/jonlamb-gh.pinephone-rs-display-prototype/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.53-1/beta-2021-05-08/gh/jonlamb-gh.pinephone-rs-display-prototype/log.txt</a></li>
</ul>



<a name="239602066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602066">(May 20 2021 at 14:34)</a>:</h4>
<p>if generate-lockfile is the wrong command to use to get the migration to happen, we should alter crater of course, but wanted to see if there were thoughts on how this should be done</p>



<a name="239602085"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602085" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602085">(May 20 2021 at 14:35)</a>:</h4>
<p>(happy to file an issue as well)</p>



<a name="239602094"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602094" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602094">(May 20 2021 at 14:35)</a>:</h4>
<p><em>looks</em></p>



<a name="239602328"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602328" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602328">(May 20 2021 at 14:36)</a>:</h4>
<p>I'd need to dig in more, a lockfile should only need updating (in theory) if something substantively needs changing (other than the encoding format)</p>



<a name="239602369"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602369" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602369">(May 20 2021 at 14:36)</a>:</h4>
<p><code>generate-lockfile</code> is not what you want for switching encodings, that starts from scratch and updates all deps</p>



<a name="239602403"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602403" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602403">(May 20 2021 at 14:36)</a>:</h4>
<p>but there shouldn't, in theory, ever been a desire to update simply the encoding of the lock file</p>



<a name="239602420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602420">(May 20 2021 at 14:37)</a>:</h4>
<p>that's indicative of a bug in Cargo</p>



<a name="239602472"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602472" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602472">(May 20 2021 at 14:37)</a>:</h4>
<p>right, that was my assumption too. I think generate-lockfile is the wrong thing but regardless, we shouldn't be hitting this :)</p>



<a name="239602480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602480">(May 20 2021 at 14:37)</a>:</h4>
<p>Would an issue be helpful?</p>



<a name="239602630"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602630" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602630">(May 20 2021 at 14:38)</a>:</h4>
<p>let me dig in first</p>



<a name="239602667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602667">(May 20 2021 at 14:38)</a>:</h4>
<p>why do you pass in <code>--locked</code> to begin with?</p>



<a name="239602723"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602723" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602723">(May 20 2021 at 14:38)</a>:</h4>
<p>Passing in <code>--locked</code> and then running <code>generate-lockfile</code> if it fails sort of defeats the purpose of a lock file</p>



<a name="239602748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602748">(May 20 2021 at 14:39)</a>:</h4>
<p>Sorry, I meant to work on a PR for this.</p>



<a name="239602757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602757">(May 20 2021 at 14:39)</a>:</h4>
<p>it thwarts Cargo's default of incrementally updating it as necessary</p>



<a name="239602808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602808">(May 20 2021 at 14:39)</a>:</h4>
<p>But yea, I think removing <code>--locked</code> and <code>generate-lockfile</code> is the right way to go.</p>



<a name="239602944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602944">(May 20 2021 at 14:40)</a>:</h4>
<p>hm</p>



<a name="239602973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239602973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239602973">(May 20 2021 at 14:40)</a>:</h4>
<p>Yeah I mean that side of crater definitely seems wrong</p>



<a name="239603026"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603026" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603026">(May 20 2021 at 14:40)</a>:</h4>
<p>but my question is sort of "why is cargo forcing an update" -- usually, like on 1.52 -- this worked OK</p>



<a name="239603270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603270">(May 20 2021 at 14:42)</a>:</h4>
<p>yes that's what I'm investigating right now</p>



<a name="239603476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603476">(May 20 2021 at 14:43)</a>:</h4>
<p>ok I see what's happening, and ... I really don't want to have to fix this ...</p>



<a name="239603599"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603599" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603599">(May 20 2021 at 14:44)</a>:</h4>
<p><a href="https://github.com/rust-lang/cargo/blob/6ca6dd0bffaf8d4011f1c8793dcb534838b788a8/src/cargo/ops/lockfile.rs#L184-L186">this comparison</a> is returning false which causes Cargo to think that a substantive update is happening</p>



<a name="239603729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603729">(May 20 2021 at 14:45)</a>:</h4>
<p>Arguably a substantive update <em>is</em> happening. The problem is the old resolve has <code>DefaultBranch</code> (no <code>branch=master</code>) and the new resolve has <code>branch=master</code>. Historical versions of Cargo considered these equivalent. New versions of Cargo do not consider these equivalent.</p>



<a name="239603814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603814">(May 20 2021 at 14:45)</a>:</h4>
<p>We could try to add in yet more gobs of "ok say <code>DefaultBranch</code> and <code>Branch("master")</code> are equivalent" but we already have way too many of those in Cargo</p>



<a name="239603847"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603847" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603847">(May 20 2021 at 14:45)</a>:</h4>
<p>I hope to rip all that out like a year from now because it's just awful to look at</p>



<a name="239603866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603866">(May 20 2021 at 14:45)</a>:</h4>
<p>and literally no one needs it after transitioning lock file formats</p>



<a name="239603989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239603989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239603989">(May 20 2021 at 14:46)</a>:</h4>
<p>so the "fix" here, if one, would be to update that location in Cargo (this is a game of whack-a-mole at this point) to consider the two branch directives equal</p>



<a name="239604069"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239604069" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239604069">(May 20 2021 at 14:46)</a>:</h4>
<p>it's not impossible but... I would rather not do it...</p>



<a name="239604078"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239604078" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239604078">(May 20 2021 at 14:46)</a>:</h4>
<p>Would running something like <code>cargo metadata</code> or whatever before the cargo fetch --locked suffice to <em>only</em> transition lockfile formats and such, i.e., not actually updating any deps?</p>



<a name="239604115"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239604115" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239604115">(May 20 2021 at 14:47)</a>:</h4>
<p>(or maybe just cargo fetch w/o --locked is enough)</p>



<a name="239604235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239604235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239604235">(May 20 2021 at 14:47)</a>:</h4>
<p>I don't really understand why Crater is passing --locked, as my mental model is that cargo won't just go updating lockfiles <em>anyway</em></p>



<a name="239604452"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239604452" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239604452">(May 20 2021 at 14:48)</a>:</h4>
<p>omitting <code>--locked</code> is enough</p>



<a name="239604555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239604555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239604555">(May 20 2021 at 14:49)</a>:</h4>
<p>hm, ok, I personally do not think we <em>have</em> to fix this.</p>



<a name="239604669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239604669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239604669">(May 20 2021 at 14:50)</a>:</h4>
<p>it's a bit annoying that it's a version upgrade that sort of represents a MSRV bump though, right?</p>



<a name="239604851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239604851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239604851">(May 20 2021 at 14:51)</a>:</h4>
<p>We'll likely want to remove --locked from crater though (cc <span class="user-mention" data-user-id="121055">@Pietro Albini</span>)</p>



<a name="239605126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239605126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239605126">(May 20 2021 at 14:52)</a>:</h4>
<p>I don't think this is different from any other real change that causes msrv to bup</p>



<a name="239605144"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239605144" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239605144">(May 20 2021 at 14:52)</a>:</h4>
<p>if you want a lower msrv you develop with that version of rust</p>



<a name="239605386"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239605386" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239605386">(May 20 2021 at 14:54)</a>:</h4>
<p>sure, sure</p>



<a name="239605419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239605419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239605419">(May 20 2021 at 14:54)</a>:</h4>
<p>just somewhat rare that we actually change cargo enough to need it</p>



<a name="239605475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239605475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239605475">(May 20 2021 at 14:55)</a>:</h4>
<p>but sounds good, I'll work on the crater patch and PR and likely rerun the subset of crates which failed, I'm not triaging the 1,500 broken crates by hand :)</p>



<a name="239606333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239606333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239606333">(May 20 2021 at 14:59)</a>:</h4>
<p>it's... unfortunate that bumping the version changes the lockfile</p>



<a name="239606360"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239606360" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239606360">(May 20 2021 at 15:00)</a>:</h4>
<p>is the new lockfile only supported on 1.53? or is it supported on older versions too?</p>



<a name="239607522"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239607522" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239607522">(May 20 2021 at 15:06)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I think it is supported back to 1.47</p>



<a name="239607698"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239607698" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239607698">(May 20 2021 at 15:07)</a>:</h4>
<p>ok if it's supported by a lot of past versions (like &gt;= 1.47) I think it's fine</p>



<a name="239607934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239607934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239607934">(May 20 2021 at 15:08)</a>:</h4>
<p>the worry I have is if the new lockfile only works in 1.53, so multiple people collaborating on the same project have to either not commit the updated <code>Cargo.lock</code> in git or they have to coordinate updating with everyone</p>



<a name="239611272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/git%20dep%20getting%20updated%20in%20crater%20on%201.53%20beta/near/239611272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta.html#239611272">(May 20 2021 at 15:29)</a>:</h4>
<p>That would be bad. We never intentionally do that.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>